Cleanup geoipRequired and uaRequired #31173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
|
retest |
💚 Build Succeeded |
kaiyan-sheng
added
the
Team:Infra Monitoring UI - DEPRECATED
|
@ycombinator Could you review this one, I remember you created / touched this code? :-) |
ycombinator
approved these changes
Feb 16, 2019
There was a problem hiding this comment.
Code changes LGTM.
Just wanted to note that I tried out master before I tried this PR and I couldn't find any tutorial that had these GeoIP or UA plugin instructions in it. I believe that's because all tutorials using Filebeat instructions were setting geoipRequired and uaRequired to false before passing them to the instruction generation functions.
So, in effect, the tutorials looked the same to me before and after this PR. Hopefully this is expected?
|
@ycombinator Yes thank you for the review! #30866 changed all |
ycombinator
pushed a commit
to ycombinator/kibana
that referenced
this pull request
Apr 5, 2019
* Cleanup geoipRequired and uaRequired * Remove geoip and user-agent plugins in chinese translations
ycombinator
pushed a commit
to ycombinator/kibana
that referenced
this pull request
Apr 5, 2019
* Cleanup geoipRequired and uaRequired * Remove geoip and user-agent plugins in chinese translations
ycombinator
pushed a commit
to ycombinator/kibana
that referenced
this pull request
Apr 5, 2019
* Cleanup geoipRequired and uaRequired * Remove geoip and user-agent plugins in chinese translations
ycombinator
added a commit
that referenced
this pull request
Apr 5, 2019
ycombinator
added a commit
that referenced
this pull request
Apr 5, 2019
ycombinator
added a commit
that referenced
this pull request
Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Elasticsearch 7.0 the geoip and the user_agent processor as shipped by default. The step to install geoip and the user_agent plugins is removed in #30866. This PR is to remove code that uses geoipRequired and uaRequired from Kibana.